Re: [PATCH RFC] kvm: optimize out smp_mb using srcu_read_unlock
From: Paul E. McKenney
Date: Wed Oct 30 2013 - 16:16:06 EST
On Wed, Oct 30, 2013 at 09:09:29PM +0200, Michael S. Tsirkin wrote:
> I noticed that srcu_read_lock/unlock both have a memory barrier,
> so just by moving srcu_read_unlock earlier we can get rid of
> one call to smp_mb().
> Unsurprisingly, the gain is small but measureable using the unit test
> vmcall 1407
> vmcall 1357
> Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
> I didn't stress test this yet, sending out for early review/flames.
> Paul, could you review this patch please?
> Documentation/memory-barriers.txt says that unlock has a weaker
> uni-directional barrier, but in practice srcu_read_unlock calls
> Is it OK to rely on this? If not, can I add
> smp_mb__after_srcu_read_unlock (making it an empty macro for now)
> so we can avoid an actual extra smp_mb()?
Please use smp_mb__after_srcu_read_unlock(). After all, it was not
that long ago that srcu_read_unlock() contained no memory barriers,
and perhaps some day it won't need to once again.
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 8617c9d..a48fb36 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -5949,8 +5949,10 @@ restore:
> /* We should set ->mode before check ->requests,
> * see the comment in make_all_cpus_request.
> + *
> + * srcu_read_unlock below acts as a memory barrier.
> - smp_mb();
> + srcu_read_unlock(&vcpu->kvm->srcu, vcpu->srcu_idx);
> @@ -5960,12 +5962,11 @@ restore:
> + vcpu->srcu_idx = srcu_read_lock(&vcpu->kvm->srcu);
> r = 1;
> goto cancel_injection;
> - srcu_read_unlock(&vcpu->kvm->srcu, vcpu->srcu_idx);
> if (req_immediate_exit)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/