Re: [PATCH] bnx2: Use dev_kfree_skb_any() in bnx2_tx_int()

From: Cong Wang
Date: Wed Oct 30 2013 - 15:23:57 EST


On Tue, Oct 29, 2013 at 11:40 PM, David Miller <davem@xxxxxxxxxxxxx> wrote:
> From: Cong Wang <xiyou.wangcong@xxxxxxxxx>
> Date: Tue, 29 Oct 2013 20:50:08 -0700
>
>> Normally ->poll() is called in softirq context, while netpoll could
>> be called in any context depending on its caller.
>
> It still makes amends to make the execution context still looks
> "compatible" as far as locking et al. is concerned.

Adjusting netpoll code for IRQ context is much harder
than just calling dev_kfree_skb_any()...

What's more, we have similar change before:

commit ed79bab847d8e5a2986d8ff43c49c6fb8ee3265f
Author: Eric Dumazet <eric.dumazet@xxxxxxxxx>
Date: Wed Oct 14 14:36:43 2009 +0000

virtio_net: use dev_kfree_skb_any() in free_old_xmit_skbs()
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/