Re: [PATCH 01/12] sb_edac: move PCI IDs to pci_ids.h

From: Borislav Petkov
Date: Wed Oct 30 2013 - 12:40:33 EST


On Wed, Oct 30, 2013 at 12:26:55PM -0400, Aristeu Rozanski wrote:
> According to the comment, it should be done before submitting upstream.
>
> Signed-off-by: Aristeu Rozanski <arozansk@xxxxxxxxxx>
> ---
> drivers/edac/sb_edac.c | 21 ++-------------------
> include/linux/pci_ids.h | 11 +++++++++++
> 2 files changed, 13 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
> index e04462b..4cdd948 100644
> --- a/drivers/edac/sb_edac.c
> +++ b/drivers/edac/sb_edac.c
> @@ -57,26 +57,9 @@ static int probed;
> */
>
> /*
> - * FIXME: For now, let's order by device function, as it makes
> - * easier for driver's development process. This table should be
> - * moved to pci_id.h when submitted upstream

Why, is anything else besides sb_edac.c using those?

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/