Re: [RFC/PATCH v2 1/3] usb: gadget: add quirks field to struct usb_gadget

From: David Cohen
Date: Wed Oct 30 2013 - 12:22:27 EST

diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h
index 942ef5e..7014ad9 100644
--- a/include/linux/usb/gadget.h
+++ b/include/linux/usb/gadget.h
@@ -540,6 +540,11 @@ struct usb_gadget {
struct device dev;
unsigned out_epnum;
unsigned in_epnum;
+ u32 quirks;
+/* epout requires buffer size to be aligned to MaxPacketSize */

If you decide to go through with this, it might be better to define a
series of single-bit flags instead of a single "quirks" field. For

unsigned quirk_ep_out_aligned_size:1;

Yes, other people (including me!) have done it your way in the past,
but now this seems to make more sense.

It would be less error-prone. I'll change it.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at