Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver (v3)

From: Frank Haverkamp
Date: Wed Oct 30 2013 - 07:20:14 EST

Hi Greg,

Am Freitag, den 25.10.2013, 16:21 +0100 schrieb Greg KH:
> On Fri, Oct 25, 2013 at 04:00:44PM +0200, Frank Haverkamp wrote:
> > > And why are you doing debug stuff through the ioctl interface? Please
> > > move that to debugfs if you really want/need that information, it does
> > > not belong in an ioctl.
> >
> > I will look into that. We need that information per card when it fails.
> People put per-card information in debugfs all the time, look at the USB
> host controller files in debugfs for an example of how to do this.

Thanks for pointing me to the example. I moved some of my former sysfs
interfaces to debugfs. Especially those which were printing out more
than one item. I guess you don't like those in sysfs anyways.

> thanks,
> greg k-h

I re-posted our driver in "[PATCH] Generic WorkQueue Engine (GenWQE)
device driver (v4)" and addressed Ryans comments too.

Some of the module parameters I got rid of, some others I turned into
debugfs interfaces. Again others I replaced by constants with proven
default values. For those I kept, I added comments why I want them as
parameters still.



To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at