RE: [char-misc-next 1/8] mei: debugfs: validate dev is not null

From: Winkler, Tomas
Date: Wed Oct 30 2013 - 03:16:16 EST


>
> On Mon, Oct 21, 2013 at 10:05:36PM +0300, Tomas Winkler wrote:
> > make static analyzer happy
>
> That's a stupid analyzer.
>
> Sorry, this case can never be true, so don't check for it. Fix your
> analyzer.
>
> > and validate dev argument before dereferencing
>
> Again, no need to do so, it's always set properly.
>
> sorry, I can't take this.

Fair enough, I didn't like that patch myself now I have other confirmation that this is stupid.

Tomas

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/