Re: [PATCH] UAPI: include <asm/byteorder.h> in linux/raid/md_p.h

From: NeilBrown
Date: Wed Oct 30 2013 - 02:13:20 EST


On Tue, 29 Oct 2013 13:28:58 +0100 Aurelien Jarno <aurelien@xxxxxxxxxxx>
wrote:

> linux/raid/md_p.h is using conditionals depending on endianess and fails
> with an error if neither of __BIG_ENDIAN, __LITTLE_ENDIAN or
> __BYTE_ORDER are defined, but it doesn't include any header which can
> define these constants. This make this header unusable alone.
>
> This patch adds a #include <asm/byteorder.h> at the beginning of this
> header to make it usable alone. This is needed to compile klibc on MIPS.
>
> Signed-off-by: Aurelien Jarno <aurelien@xxxxxxxxxxx>
> ---
> include/uapi/linux/raid/md_p.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/uapi/linux/raid/md_p.h b/include/uapi/linux/raid/md_p.h
> index fe1a540..f7cf7f3 100644
> --- a/include/uapi/linux/raid/md_p.h
> +++ b/include/uapi/linux/raid/md_p.h
> @@ -16,6 +16,7 @@
> #define _MD_P_H
>
> #include <linux/types.h>
> +#include <asm/byteorder.h>
>
> /*
> * RAID superblock.

Makes sense. Applied. Thanks.

NeilBrown

Attachment: signature.asc
Description: PGP signature