Re: [PATCH] bnx2: Use dev_kfree_skb_any() in bnx2_tx_int()

From: Cong Wang
Date: Tue Oct 29 2013 - 23:50:46 EST


On Tue, Oct 29, 2013 at 7:42 PM, David Miller <davem@xxxxxxxxxxxxx> wrote:
> From: David Mackey <tdmackey@xxxxxxxxxxxxxxxx>
> Date: Tue, 29 Oct 2013 15:16:38 -0700
>
>> Using dev_kfree_skb_any() will resolve the below issue when a
>> netconsole message is transmitted in an irq.
> ...
>> Signed-off-by: David Mackey <tdmackey@xxxxxxxxxxxxxxxx>
>
> This is absolutely not the correct fix.
>
> The netpoll facility must invoke ->poll() in an environment which
> is compatible, locking and interrupt/soft-interrupt wise, as that
> in which it is normally called.
>

Normally ->poll() is called in softirq context, while netpoll could
be called in any context depending on its caller.

Also, netpoll disables IRQ for tx, which is another difference.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/