[PATCH v7 2/3] Staging: zram: Fix decrement of variable by calling bdput()

From: Rashika Kheria
Date: Tue Oct 29 2013 - 19:13:11 EST

As suggested by Jerome Marchand "The code in reset_store get the block device
(bdget_disk()) but it does not put it (bdput()) when it's done using it.
The usage count is therefor incremented but never decremented."

Hence, this patch introduces a call to bdput() to decrement the variable after usage.

Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Rashika Kheria <rashika.kheria@xxxxxxxxx>

This revision fixes the following issues of the previous revision-
Handle more error cases

drivers/staging/zram/zram_drv.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c
index d640a8f..592e760 100644
--- a/drivers/staging/zram/zram_drv.c
+++ b/drivers/staging/zram/zram_drv.c
@@ -664,6 +664,9 @@ static ssize_t reset_store(struct device *dev,

/* Make sure all pending I/O is finished */
+ bdput(bdev);
+ bdput(bdev->bd_holders);
+ bdput(do_reset);

zram_reset_device(zram, true);
return len;

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/