Re: [PATCH v2 05/13] uprobes: add arch write opcode hook

From: Oleg Nesterov
Date: Tue Oct 29 2013 - 15:58:12 EST

On 10/28, Oleg Nesterov wrote:
> Yes, yes, sorry for confusion. What I actually tried to suggest is
> something like the trivial patch below.
> Then arm can do:
> uprobe_opcode_t arch_uprobe_swbp_insn(struct arch_uprobe *auprobe)
> {
> return __opcode_to_mem_arm(auprobe->bpinsn);
> }
> No?
> > I notice there don't seem to be any alternative set_swbp functions
> > in the (rc6) kernel tree
> Yes... I think we should simply make it "static". And set_orig_insn()
> too.

Or. arm can actually reimplement set_swbp(). This doesn't mean the
duplication of write_opcode() code, we can simply export this helper.

Either way is imho better than this patch. Unless I missed something.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at