Re: [PATCH] arch: use ASM_NL instead of ';' for assembler new line character in the macro

From: David Howells
Date: Tue Oct 29 2013 - 06:39:51 EST

Chen Gang <gang.chen@xxxxxxxxxxx> wrote:

> > And you also need to fix kernel/modsign_certificate.S as part of same patchset as
> > that is where the problem started in first place.
> >
> Hmm... can that be another patch?
> For "kernel/modsign_certificate.S", I recommend to expand the macro
> which will shrink code line, either need not include additional header
> file, I feel that will be simpler for both code reader and writers.

I recommend leaving that file alone. That gets moved to a .S file in patches
queued in the security tree.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at