Re: [PATCH 0/4] perf tools: Fix -g option handling

From: Ingo Molnar
Date: Tue Oct 29 2013 - 06:25:53 EST



* Jiri Olsa <jolsa@xxxxxxxxxx> wrote:

> On Sun, Oct 27, 2013 at 07:56:05AM +0100, Ingo Molnar wrote:
> >
> > * Jiri Olsa <jolsa@xxxxxxxxxx> wrote:
> >
> > > On Sat, Oct 26, 2013 at 04:25:32PM +0200, Jiri Olsa wrote:
> > > > hi,
> > > > changing the '-g/-G' options for record/top commands
> > > > to take NO argument and enable unwind method based
> > > > on .perfconfig setup (using FP by default).
> > > >
> > > > The current -g option parsing moves into the
> > > > '--call-graph' option.
> > >
> > > forgot to mention branch:
> > >
> > > git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
> > > perf/cc
> >
> > I tested it - works perfectly now for me:
> >
> > Acked-and-tested-by: Ingo Molnar <mingo@xxxxxxxxxx>
> >
> > You might want to give --call-graph a single letter option name as well,
> > -g, -G, -c, -C are all taken already, but both -l and -L are still
> > available - maybe use -L for it?
>
> ok, I'll addd the -L
> I'll send it with fixies for other comments

Please do it against tip:perf/core aac898548d04 or later (I just
pushed it out, it might take a few minutes to propagate), the most
important parts are in perf/urgent already (which is merged into
aac898548d04), we can do the rest for v3.13 as delta fixlets.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/