Re: [PATCH 5/6] perf timechart: add support for -P and -T intimechart recording

From: Stanislav Fomichev
Date: Tue Oct 29 2013 - 05:52:08 EST


> It should be ARRAY_SIZE(old_power_args).
Thanks :-)

> Do we really need to separate the option and usage for record? AFAICS
> it does exactly same thing..
Yes, we do. Some options which are defined for timechart are undefined
for record (like -i, -o, etc), so we want to get an error in case of wrong
options.

And we separate usage, because it's different in timechart:
"perf timechart [<options>] {record}",

and record:
"perf timechart record [<options>]",

We may share usage, but we need it to be something (confusing?) like:
"perf timechart [<options>] {record [<options>]}",
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/