Re: [PATCH 3/6] perf timechart: add support for displaying onlytasks related data

From: Stanislav Fomichev
Date: Tue Oct 29 2013 - 05:33:40 EST


> Hmm.. double negation is always confusing to me. :-/ How about making
> it a boolean option that sets "task_only" variable?
Ok.

> Also need to update the doc. And what if user gives -P and -T options
> at the same time?
Is something like this is enough (or you'd like some printout with error
details)?

if (!proc_num && task_only)
usage_with_options(timechart_usage, options);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/