Re: [PATCH 3/4] VFIO: pci: amend vfio-pci for explicit binding viasysfs only

From: Alex Williamson
Date: Mon Oct 28 2013 - 13:47:57 EST


On Fri, 2013-10-11 at 01:27 -0500, Kim Phillips wrote:
> Force the vfio-pci driver to only be bound explicitly via sysfs to avoid
> conflics with other drivers in the event of a hotplug.

We can't break userspace, so we can't disable the current method of
binding devices to vfio-pci. We can add a new method and perhaps
deprecate the existing mechanism to be removed at some point in the
future. Thanks,

Alex

> Signed-off-by: Kim Phillips <kim.phillips@xxxxxxxxxx>
> ---
> drivers/vfio/pci/vfio_pci.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c
> index 6ab71b9..bdd7833 100644
> --- a/drivers/vfio/pci/vfio_pci.c
> +++ b/drivers/vfio/pci/vfio_pci.c
> @@ -901,6 +901,9 @@ static struct pci_driver vfio_pci_driver = {
> .probe = vfio_pci_probe,
> .remove = vfio_pci_remove,
> .err_handler = &vfio_err_handlers,
> + .driver = {
> + .sysfs_bind_only = true,
> + },
> };
>
> static void __exit vfio_pci_cleanup(void)



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/