Re: [PATCH]tty:vt: Add NULL check to return value of kzalloc()

From: Greg KH
Date: Mon Oct 28 2013 - 12:35:18 EST


On Tue, Oct 29, 2013 at 12:26:05AM +0800, Wang YanQing wrote:
> In extreme situation kzalloc in con_init may
> return NULL, so we should check it to prevent
> OOPS!
>
> Signed-off-by: Wang YanQing <udknight@xxxxxxxxx>
> Reported-by: rucsoftsec@xxxxxxxxx

I need a name for Reported-by: as well, not just an email.

> ---
> I don't think a system without memory to initialize
> vt could do some useful things, but this patch could
> make debug easier and improve kernel code's robustness
> in theory.

Please always run your patches through the scripts/checkpatch.pl tool
and fix the problems found there so that maintainers don't have to point
out the same thing...

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/