Re: [PATCH] arch: use ASM_NL instead of ';' for assembler new linecharacter in the macro

[Vineet Gupta]

On 10/28/2013 04:00 PM, Chen Gang wrote:
> For some toolchains, they use another character as newline in a macro
> (e.g. arc uses '`'), so for generic assembly code, need use ASM_NL (a
> macro) instead of ';' for it.
> 
> Since "linux/export.h" are mainly used for exporting work, then our fix
> more likely belongs to "linux/linkage.h", and we need add the related
> checking in "linkage.h".
> 
> Also need notice 80 columns wrap, and '\t' for each line.
> 
> 
> Signed-off-by: Chen Gang <gang.chen@xxxxxxxxxxx>
> ---
>  arch/arc/include/asm/linkage.h    |    2 +
>  include/asm-generic/vmlinux.lds.h |  350 +++++++++++++++++++------------------
>  include/linux/linkage.h           |   19 +

Like Max said, please drop the linker script bits - they are OK - otherwise ARC
kernel won't have been building at all.

And you also need to fix kernel/modsign_certificate.S as part of same patchset as
that is where the problem started in first place.

-Vineet
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/