Re: [v1 1/2] xen/p2m: Create identity mappings for PFNsbeyound E820 and PCI BARs

[Jan Beulich]

>>> On 26.10.13 at 00:08, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote:
> On Fri, Oct 25, 2013 at 9:03 AM, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> wrote:
>> +               unsigned long pfn, start, end, ok_pfns;
>> +               char bus_addr[64];
>> +               char *fmt;
>> +
>> +               if (!pci_resource_len(pci_dev, i))
>> +                       continue;
>> +
>> +               if (pci_resource_flags(pci_dev, i) == IORESOURCE_IO)
> 
> You probably want:
> 
>     if (pci_resource_flags(pci_dev, i) & IORESOURCE_IO)
> 
> here.  And I don't understand what you're doing below, but my
> impression is you only care about MEM regions, not IO regions, so it
> seems like you might want to skip IO completely.

Yes indeed.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/