Re: [PATCH] mmc: sdhci: dove: Fix build breakage

From: Thierry Reding
Date: Mon Oct 28 2013 - 03:48:07 EST


On Sun, Oct 27, 2013 at 08:56:55AM -0400, Chris Ball wrote:
> Hi,
>
> On Wed, Oct 23 2013, Thierry Reding wrote:
> > Commit 2d7c51f (mmc: sdhci: Use work structs instead of tasklets)
> > converts tasklets to work structs, but typos the conversion in the Dove
> > driver.
> >
> > Signed-off-by: Thierry Reding <treding@xxxxxxxxxx>
> > ---
> > drivers/mmc/host/sdhci-dove.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mmc/host/sdhci-dove.c b/drivers/mmc/host/sdhci-dove.c
> > index 45c7f25..95f1076 100644
> > --- a/drivers/mmc/host/sdhci-dove.c
> > +++ b/drivers/mmc/host/sdhci-dove.c
> > @@ -39,7 +39,7 @@ static irqreturn_t sdhci_dove_carddetect_irq(int irq, void *data)
> > {
> > struct sdhci_host *host = data;
> >
> > - schedule_schedule(&host->card_detect_work);
> > + schedule_work(&host->card_detect_work);
> > return IRQ_HANDLED;
> > }
>
> Thanks, Thierry -- I hope it's okay with you if I merge your fix into
> the original patch and add your S-o-b to that patch:
>
> Signed-off-by: Anton Vorontsov <avorontsov@xxxxxxxxxx>
> Signed-off-by: Jeremie Samuel <jeremie.samuel.ext@xxxxxxxxxx>
> [treding: Fix typo causing sdhci-dove build breakage]
> Signed-off-by: Thierry Reding <treding@xxxxxxxxxx>
> Signed-off-by: Chris Ball <cjb@xxxxxxxxxx>

Sure, no problem.

Thierry

Attachment: pgp00000.pgp
Description: PGP signature