Re: [PATCH v2] mmc:sdhci-pci: Add Support of O2Mirco/BayHubTech SD Host

From: Chris Ball
Date: Sun Oct 27 2013 - 09:03:07 EST

Hi Peter,

On Wed, Oct 23 2013, Peter Guo wrote:
> Do you have any comments on this patch?

It would be nice if there were fewer magic constants in the patch, and
adding another 200 lines to sdhci-pci seems to suggest that it might
be time to split it out into sdhci-pci-o2micro.c.


- Chris.
Chris Ball <cjb@xxxxxxxxxx> <>
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at