Re: [PATCHv2 1/3] Input: twl4030-keypad - add device tree support
From: Pavel Machek
Date: Sun Oct 27 2013 - 07:48:01 EST
> > > + * keypad,num-rows and keypad,num-columns are required.
> > Is "keypad," prefix neccessary here?
> See Documentation/devicetree/bindings/input/matrix-keymap.txt
> > > +Optional Properties specific to linux:
> > > +- linux,keypad-no-autorepeat: do no enable autorepeat feature.
> > "do not autorepeat". Plus I do not see what is Linux specifc about not
> > autorepeating... Other systems will likely know about autorepeat, too.
> This property has already been used like this for
> samsung-keypad, stmpe-keypad, omap-keypad and
Ok. But you still have a typo. "do no enable" => "do not enable".
> > > +#if IS_ENABLED(CONFIG_OF)
> > I'm probably missing something here, but why not #ifdef CONFIG_OF?
> I have been told for other drivers, that IS_ENABLED() is
> the prefered way to check for configuration these days.
CONFIG_OF can not be module, using IS_ENABLED() on it is just wrong.
> > > @@ -381,7 +426,7 @@ static int twl4030_kp_probe(struct platform_device *pdev)
> > >
> > > input_set_capability(input, EV_MSC, MSC_SCAN);
> > > /* Enable auto repeat feature of Linux input subsystem */
> > > - if (pdata->rep)
> > > + if (!kp->no_autorepeat)
> > > __set_bit(EV_REP, input->evbit);
> > >
> > Double negation is nasty to read. I believe code would be more
> > readable if you switched logic to kp->autorepeat.
> I was thinking about the same when writing it, but decided
> against it, since it will just move the double negation to
> the variable initialization.
Well, the property should be linux,keypad-autorepeat in the first
place, but it is too late to change that.
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/