Re: [PATCH V2] printk: pr_debug_ratelimited: check state first toreduce "callbacks suppressed" messages

From: Krzysztof Mazur
Date: Sun Oct 27 2013 - 06:34:14 EST

On Sat, Oct 26, 2013 at 08:41:53PM -0700, Joe Perches wrote:
> pr_debug_ratelimited should be coded similarly to dev_dbg_ratelimited
> to reduce the "callbacks suppressed" messages.
> Add #include <linux/dynamic_debug.h> to printk.h. Unfortunately, this
> new #include must be after the prototype/declaration of function printk.
> It may be better to split out these _ratelimited declarations into
> a separate file one day.
> Any use of these pr_<foo>_ratelimited functions must also have another
> specific #include <ratelimited.h>. Most users have this done indirectly
> via #include <linux/kernel.h>
> printk.h may not #include <linux/ratelimit.h> as it causes circular
> dependencies and compilation failures.
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> ---
> V2: Fix #include dependencies and typos.
> Compile tested with and without CONFIG_DYNAMIC_DEBUG

I've tested both patches without CONFIG_DYNAMIC_DEBUG and
with enabled and disabled debugging with CONFIG_DYNAMIC_DEBUG
and everything seems work correctly.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at