Re: [PATCH 02/11] asmlinkage: Make __iowrite32_copy visible
From: Ingo Molnar
Date: Sat Oct 26 2013 - 06:02:48 EST
* Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
> From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> This is a assembler function on x86, so it should be visible.
> Cc: x86@xxxxxxxxxx
> Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> include/linux/io.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
NAK for this and all the other patches, for two technical reasons:
- Please squash most of these trivial patches into a single patch
that also describes the context completely, at least the x86 and
core kernel ones that I'd apply within a single maintenance
- Please use the customary changelog style we use in the kernel:
" Current code does (A), this has a problem when (B).
We can improve this doing (C), because (D)."
Just saying 'because of LTO' is not enough, obviously. You need to
talk about and explain things Andi. Being cryptic, mysterious and
curt might work with some ladies, but it's outright harmful on lkml.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/