Re: [PATCHv6 2/3] Input: twl4030-pwrbutton: use dev_err for errors

From: Aaro Koskinen
Date: Fri Oct 25 2013 - 16:05:40 EST


Hi,

On Thu, Oct 24, 2013 at 04:48:45PM +0200, Sebastian Reichel wrote:
> Use dev_err() to output errors instead of dev_dbg().
>
> Signed-off-by: Sebastian Reichel <sre@xxxxxxxxxx>

Reviewed-by: Aaro Koskinen <aaro.koskinen@xxxxxx>

> ---
> drivers/input/misc/twl4030-pwrbutton.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/misc/twl4030-pwrbutton.c b/drivers/input/misc/twl4030-pwrbutton.c
> index a3a0fe3..48639ff 100644
> --- a/drivers/input/misc/twl4030-pwrbutton.c
> +++ b/drivers/input/misc/twl4030-pwrbutton.c
> @@ -74,13 +74,13 @@ static int twl4030_pwrbutton_probe(struct platform_device *pdev)
> IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING,
> "twl4030_pwrbutton", pwr);
> if (err < 0) {
> - dev_dbg(&pdev->dev, "Can't get IRQ for pwrbutton: %d\n", err);
> + dev_err(&pdev->dev, "Can't get IRQ for pwrbutton: %d\n", err);
> goto free_input_dev;
> }
>
> err = input_register_device(pwr);
> if (err) {
> - dev_dbg(&pdev->dev, "Can't register power button: %d\n", err);
> + dev_err(&pdev->dev, "Can't register power button: %d\n", err);
> goto free_irq;
> }
>
> --
> 1.8.4.rc3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/