Re: [PATCH] scripts/ find unused Kconfig parameters

From: Michael Opdenacker
Date: Fri Oct 25 2013 - 09:38:58 EST

Hi Joe,

Thank you very much for your review!

On 10/24/2013 09:30 AM, Joe Perches wrote:
> On Thu, 2013-10-24 at 07:23 +0200, Michael Opdenacker wrote:
>> +def count_param(param):
>> +
>> + global source_file, bad_params_in_file
>> +
>> + if os.path.isdir('.git'):
>> + # Use git grep when available
>> + count = subprocess.check_output('git grep ' + param + '| grep -v defconfig | wc -l', shell=True)
>> + else:
>> + # Fallback to regular grep
>> + count = subprocess.check_output('grep -R ' + param + ' . | grep -v defconfig | wc -l', shell=True)
> Doesn't the grep need -w?
Using "-w" is a good idea, and this way I can eliminate false negatives
(for example finding matches for "PRINTK_TIME" when I'm looking for
plain "PRINTK"). The only this is that I then need to look for both
"PARAM" (in Kconfig files, in case the parameter is just used for
dependency management), and for "CONFIG_PARAM" (in source files).
> Also, the regular grep could probably use something like
> 'grep -R -w --max-count=2 --include="*.[chS]"'
I can definitely use "--max-count=2".

'--include="*.[chS]"' is more problematic because it excludes Kconfig
files. I'll use "-I" instead to just ignore binary files.

I'll soon send an update taking this into account.

Don't hesitate to send more comments.

Thanks again,


Michael Opdenacker, CEO, Free Electrons
Embedded Linux, Kernel and Android engineering
+33 484 258 098

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at