Re: [PATCH] device: Make dev_WARN/dev_WARN_ONCE print device as wellas driver name

From: Felipe Balbi
Date: Thu Oct 24 2013 - 22:29:39 EST

On Thu, Oct 24, 2013 at 03:42:33PM -0600, Bjorn Helgaas wrote:
> dev_WARN() and dev_WARN_ONCE() are annoying because (1) they include
> only the driver name, not the device name, and (2) they print a spurious
> newline in the middle. This results in messages like this that are less
> useful than they should be:
> [ 40.094995] Device pcieport
> disabling already-disabled device
> This patch makes them work more like dev_printk().
> Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>

Pretty cool, much nicer output indeed :-)

Reviewed-by: Felipe Balbi <balbi@xxxxxx>


Attachment: signature.asc
Description: Digital signature