Re: [PATCH] perf: Fix library detection when building without libelf
From: Patrick Palka
Date: Thu Oct 24 2013 - 16:36:58 EST
On Thu, Oct 24, 2013 at 4:13 PM, Arnaldo Carvalho de Melo
> Em Wed, Oct 23, 2013 at 10:51:09PM -0400, Patrick Palka escreveu:
>> When I attempt to build perf on a system with slang but without libelf,
>> 'make' would wrongly complain that the slang library could not be found.
>> It turns out that this was happening because we are not filtering -lelf
>> from EXTLIBS early enough. As a result, the library test for slang
>> (ditto for gtk, libaudit, etc) erroneously passes -lelf to try-cc, which
>> of course fails on a system without libelf.
>> This patch makes the filtering of -lelf from EXTLIBS occur right after
>> testing for libelf support, so that the subsequent library tests will
>> not erroneously pass -lelf to try-cc when building without libelf
> Can you please check with the perf/core branch in my tree or Ingo's?
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git perf/core
> or Ingo's:
> git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git perf/core
> The feature detection was reworked and perhaps it is fixed there.
> - Arnaldo
I can't reproduce the detection failure in your branch, and a quick inspection
shows that the new feature-detection code is not subject to the kind of bug
that my patch fixed. So consider my patch obsolete.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/