Re: [PATCH] bcache: Fixed incorrect order of arguments tobio_alloc_bioset()

From: Jens Axboe
Date: Thu Oct 24 2013 - 08:04:14 EST


On Tue, Oct 22 2013, Kent Overstreet wrote:
> Signed-off-by: Kent Overstreet <kmo@xxxxxxxxxxxxx>
> Cc: linux-stable <stable@xxxxxxxxxxxxxxx> # >= v3.10
> ---
> drivers/md/bcache/request.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
> index b6a74bc..2a7f0dd 100644
> --- a/drivers/md/bcache/request.c
> +++ b/drivers/md/bcache/request.c
> @@ -1000,7 +1000,7 @@ static void request_write(struct cached_dev *dc, struct search *s)
>
> if (bio->bi_rw & REQ_FLUSH) {
> /* Also need to send a flush to the backing device */
> - struct bio *flush = bio_alloc_bioset(0, GFP_NOIO,
> + struct bio *flush = bio_alloc_bioset(GFP_NOIO, 0,
> dc->disk.bio_split);
>
> flush->bi_rw = WRITE_FLUSH;

Woops... Added.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/