Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver v2

From: Greg KH
Date: Thu Oct 24 2013 - 06:08:14 EST

On Wed, Oct 23, 2013 at 06:15:21PM +0200, Frank Haverkamp wrote:
> Rework comments:
> o Removed __DATE__ macros as suggested by Michal Marek
> o Removed startup pr_info() as suggested by Greg KH
> Plus some little things we found during test and review:
> o Removed some obsolete comments
> o Fixed a bug in the initialization path when
> genwqe_set_interrupt_capability() fails
> Greg, I tried my luck now with git send-email. Please let
> me know if that works better.

That's one of the the worst commit message that I've ever seen, you
really want this as the thing that shows up in the git commit log?

I have no idea what this code is, what it does, nor what it should do.

Also, you are using sysfs, but have no Documetation/ABI/ modifications,
which isn't allowed.

I need a whole more information before I can even start to review the
code to try to determine if it's ok or not.

greg k-h
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at