Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver
From: Greg KH
Date: Thu Oct 24 2013 - 05:54:55 EST
On Wed, Oct 23, 2013 at 11:15:25AM -0700, Guenter Roeck wrote:
> On Wed, Oct 23, 2013 at 04:22:50PM +0100, Greg KH wrote:
> > On Wed, Oct 23, 2013 at 05:06:41PM +0200, Michal Marek wrote:
> > > On 23.10.2013 16:14, Frank Haverkamp wrote:
> > > > of course you are right. Let me try again.
> > > >
> > > > I hope this looks better now:
> > > > + dev_info(&pci_dev->dev, "GenWQE driver version: %s %s%u\n",
> > > > + DRV_VERS_STRING, GENWQE_DEVNAME, cd->card_idx);
> > > > ...
> > Also, _no_ driver should ever be doing this type of "hey, look at me,
> > I'm now loaded!" type syslog spam anymore. It's pointless, and should
> > be abolished where ever possible. That's one reason we have moved to
> > the driver init type functions that make this impossible to do, and if
> > possible, I recommend doing that here as well.
> I agree. Do we have that as a general policy written down somewhere ?
> That would help in reviews with authors insisting that they absolutely
> want such messages.
So, you want something written down that no one will ever read? :)
Seriously, just push back, there's no reason we should ever take such
crud. That's one reason those new macros are there, the side benefit of
cleaning up code and removing lines was just a cover story...
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/