Re: [PATCH 10/11] blk-mq: new multi-queue block IO queueing mechanism

[Jens Axboe]

On Thu, Oct 24 2013, Dave Jones wrote:
> On Thu, Oct 24, 2013 at 10:26:03AM +0100, Jens Axboe wrote:
>  > +static struct blk_mq_hw_ctx_sysfs_entry blk_mq_hw_sysfs_ipi = {
>  > +	.attr = {.name = "ipi_redirect", .mode = S_IRUGO | S_IWUGO},
>  > +	.show = blk_mq_hw_sysfs_ipi_show,
>  > +	.store = blk_mq_hw_sysfs_ipi_store,
> 
> Is having this world writable a good idea ?

Good catch, that's a typo (should be S_IWUSR). Will fix up.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/