Re: [v5][PATCH 2/6] powerpc/book3e: store critical/machine/debugexception thread info

["âtiejun.chenâ"]

On 10/19/2013 06:43 AM, Scott Wood wrote:
> On Thu, 2013-06-20 at 18:28 +0800, Tiejun Chen wrote:
> > We need to store thread info to these exception thread info like something
> > we already did for PPC32.
> >
> > Signed-off-by: Tiejun Chen <tiejun.chen@xxxxxxxxxxxxx>
> > ---
> >   arch/powerpc/kernel/exceptions-64e.S |   15 +++++++++++++++
> >   1 file changed, 15 insertions(+)
> >
> > diff --git a/arch/powerpc/kernel/exceptions-64e.S b/arch/powerpc/kernel/exceptions-64e.S
> > index 4d8e57f..07cf657 100644
> > --- a/arch/powerpc/kernel/exceptions-64e.S
> > +++ b/arch/powerpc/kernel/exceptions-64e.S
> > @@ -67,6 +67,18 @@
> >   	std	r10,PACA_##level##_STACK(r13);
> >   #endif
> >
> > +/* Store something to exception thread info */
> > +#define	BOOK3E_STORE_EXC_LEVEL_THEAD_INFO(type)					\
> > +	ld	r14,PACAKSAVE(r13);						\
> > +	CURRENT_THREAD_INFO(r14, r14);						\
> > +	CURRENT_THREAD_INFO(r15, r1);						\
> > +	ld	r10,TI_FLAGS(r14);		     				\
> > +	std	r10,TI_FLAGS(r15);			     			\
> > +	ld	r10,TI_PREEMPT(r14);		     				\
> > +	std	r10,TI_PREEMPT(r15);		     				\
> > +	ld	r10,TI_TASK(r14);			     			\
> > +	std	r10,TI_TASK(r15);
>
> Where is "type" used?

Yes, its noting now but its worth leaving this to extend something in the future.

> BTW, no need for a BOOK3E prefix for things local to this file.

What about "EXC_LEVEL_EXCEPTION_PROLOG"? Please see next version.

Thanks,

Tiejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/