Re: [PATCH v2 2/4] perf: streamline append_chain() function

From: Waiman Long
Date: Mon Oct 21 2013 - 10:50:59 EST


On 10/19/2013 08:29 PM, Andi Kleen wrote:
Waiman Long<Waiman.Long@xxxxxx> writes:

as well as
using ?: statement which can be more efficient than the regular if
statement in some architectures.
I don't think that's true, the compiler does if conversion anyways for both.

But change seems reasonable.

-Andi



That may be true for a simple if statement. However, the condition was checked as the last of 3 tests. I doubt if the compiler is able to optimize that effectively.

-Longman
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/