Re: [PATCH 03/19] perf record: Improve write_output error message

[Jiri Olsa]

On Mon, Oct 21, 2013 at 09:07:16AM +0300, Adrian Hunter wrote:
> On 20/10/13 23:43, Jiri Olsa wrote:
> > On Fri, Oct 18, 2013 at 03:29:00PM +0300, Adrian Hunter wrote:
> >> Improve the error message from write_output() to say
> >> what failed to write and give the error number.
> >>
> >> Signed-off-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> >> ---
> >>  tools/perf/builtin-record.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
> >> index 92ca541..d269dfa 100644
> >> --- a/tools/perf/builtin-record.c
> >> +++ b/tools/perf/builtin-record.c
> >> @@ -88,7 +88,7 @@ static int write_output(struct perf_record *rec, void *buf, size_t size)
> >>  		int ret = write(rec->output, buf, size);
> >>  
> >>  		if (ret < 0) {
> >> -			pr_err("failed to write\n");
> >> +			pr_err("failed to write perf data, error: %m\n");
> > 
> > is this some kind of format magic? ;-) you wanted
> 
> It is a glibc extension.
> 
> > to print out 'ret' value, right?
> 
> No, errno
> 

ok, thanks

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/