Re: [PATCH net-next v3 3/9] static_key: WARN on usage before jump_label_init was called

From: Hannes Frederic Sowa
Date: Thu Oct 17 2013 - 21:17:00 EST


On Fri, Oct 18, 2013 at 02:50:57AM +0200, Andi Kleen wrote:
> On Thu, Oct 17, 2013 at 05:19:40PM -0400, Steven Rostedt wrote:
> > On Thu, 17 Oct 2013 07:31:57 +0200
> > Hannes Frederic Sowa <hannes@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > > Based on a patch from Andi Kleen.
> >
> > I'm fine with the patch, but the change log needs a lot more work.
> > Like, why is this needed? I know, but does anyone else?
>
> Or just merge the orininal patch. While being less verbose
> in the warning it had a full changelog.

I don't care that much which patch gets merged but I just want to
point out another difference: I added WARN_ONs on code paths without
architecture support for static_keys to help developers on platforms
without support for that.

Greetings,

Hannes

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/