Re: [PATCH 5/5] efi: Capsule update support and pstore backend

From: Matt Fleming
Date: Thu Oct 17 2013 - 07:55:36 EST


On Wed, 16 Oct, at 03:19:39PM, Matthew Garrett wrote:
> On Wed, Oct 16, 2013 at 02:51:00PM +0100, Matt Fleming wrote:
>
> > + Many EFI machines have buggy implementations of the UpdateCapsule()
> > + runtime service. This option will enable code that may not function
> > + correctly with your firmware.
>
> Where by "May not function correctly" you mean "May crash the system"?

Bingo.

> I'm a little uneasy having this run by default if enabled, even if it's
> disabled by default in the config.

What would be the canonical way to enable this feature then? Have a file
along the lines of /sys/kernel/debug/capsule_enable, where a user would
be required to,

echo 1 > /sys/kernel/debug/capsule_enable

to turn on the functionality?

--
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/