sparse: possible false report of context imbalance

From: Larry Finger
Date: Wed Oct 16 2013 - 23:24:03 EST


Hi,

Sparse reports the following:

CHECK drivers/staging/rtl8188eu/core/rtw_mlme.c
drivers/staging/rtl8188eu/core/rtw_mlme.c:1003:9: warning: context imbalance in 'rtw_free_assoc_resources' - different lock contexts for basic block

The code in question is as follows:

if (lock_scanned_queue)
spin_lock_bh(&(pmlmepriv->scanned_queue.lock));

pwlan = rtw_find_network(&pmlmepriv->scanned_queue, tgt_network->network.MacAddress);

if (lock_scanned_queue)
spin_unlock_bh(&(pmlmepriv->scanned_queue.lock));

As this fragment uses the identical test to unlock that is used to lock, and the test variable is not touched, I think this is a false indication. I am using version 0.4.4 of sparse.

Thanks,

Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/