Re: [PATCH v2] USB: cdc-acm: put delayed_wb to list

From: Xiao Jin
Date: Wed Oct 16 2013 - 20:45:15 EST


Hi, Greg,

I am sorry for the inconvenience again. I will do as what you point to
make sure the thing won't happen again in future.

On Wed, 2013-10-16 at 13:44 -0700, Greg KH wrote:
> On Tue, Oct 15, 2013 at 09:01:35AM +0800, xiao jin wrote:
> > If acm_write_start during acm suspend, write acm_wb is backuped
> > to delayed_wb. When acm resume, the delayed_wb will be started.
> > This mechanism can only record one write during acm suspend. More
> > acm write will be abandoned.
> >
> > This patch is to use list_head to record the write acm_wb during acm
> > suspend. It can ensure no acm write abandoned.
> >
> > Signed-off-by: xiao jin <jin.xiao@xxxxxxxxx>
>
> You obviously did not test this patch at all, as it breaks the build.
>
> Please get a senior Intel kernel developer to sign-off on your future
> patches so this does not happen again.
>
> greg k-h


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/