Re: [PATCH] inotify: IN_DELETE events missing in -mm

From: Jim Mostek
Date: Wed Oct 16 2013 - 16:38:37 EST



You cannot move this line of code after dentry_iput(dentry); without
considerations for locking.

Another thread can get this dentry and be changing dentry->d_flags at the
same time!
We have hit this in testing. The code must be changed to have locks (if this
field needs to be changed or ...)

In our tests, the flag 0x10 in __d_drop goes missing because this line of
code executed at the same time on another processor.



--
View this message in context: http://linux-kernel.2935.n7.nabble.com/PATCH-inotify-IN-DELETE-events-missing-in-mm-tp105372p738511.html
Sent from the Linux Kernel mailing list archive at Nabble.com.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/