Re: [PATCH v3 14/19] clk: tegra30: replace enum by binding header

From: Peter De Schrijver
Date: Wed Oct 16 2013 - 10:46:27 EST


On Tue, Oct 15, 2013 at 09:41:57PM +0200, Stephen Warren wrote:
> On 10/15/2013 08:52 AM, Peter De Schrijver wrote:
> > As the clock IDs are now specified in a header file, we can use those
> > definitions instead of maintaining an internal enum.
>
> Nit: The patch subject should say "clk: tegra:" not "clk: tegra20:" so
> that anyone looking at the tags in the subject has only one "tegra"
> value to look at, not a whole bunch of them.
>
> Would it make sense to squash patches 15, 16, 18 together (and similar
> for Tegra30) to avoid some churn i.e. the fact that the entire body of
> tegra_periph_clk_list[] gets replaced twice?

You mean do all the changes for Tegra20 and Tegra30 in 1 patch per SoC?

Cheers,

Peter.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/