Re: [PATCH v3 13/19] clk: tegra: introduce common gen4 super clock

From: Peter De Schrijver
Date: Wed Oct 16 2013 - 03:38:34 EST


On Tue, Oct 15, 2013 at 09:37:23PM +0200, Stephen Warren wrote:
> On 10/15/2013 08:52 AM, Peter De Schrijver wrote:
> > Introduce a common function which super clock initialization for Tegra114
> > and beyond.
>
> Nit: s/which/{which,that} performs/ ?
>
> For my education, why are cclk_g, cclk_lp, pll_x related to the super
> clock? I thought sclk/hclk/pclk were bus clocks, not something related
> to the CPU clock(s).

sclk (at least from tegra30 onwards) uses the same 'super clock' structure
than the CPU clocks. hclk and pclk are derived from that. Hence I considered
it sensible to define all of them in the same file.

Cheers,

Peter.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/