Re: [PATCH v3 08/19] clk: tegra: add common infra for DT clocks

From: Stephen Warren
Date: Tue Oct 15 2013 - 15:01:53 EST


On 10/15/2013 08:52 AM, Peter De Schrijver wrote:
> Introduce a common infrastructure for sharing clock initialization between
> SoCs.

> diff --git a/drivers/clk/tegra/clk.c b/drivers/clk/tegra/clk.c

> +struct clk ** __init tegra_lookup_dt_id(int clk_id,
> + struct tegra_clk *tegra_clk)
> +{
> + if (tegra_clk[clk_id].present)
> + return &clks[tegra_clk[clk_id].dt_id];
> + else
> + return NULL;

Does this need range-checking? Or do we assume that since this is an
internal function, "clk_id" will never be out-of-range?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/