Re: [PATCH 1/6] net: ip4_datagram_connect: Use correct form ofstatistics update

From: Eric Dumazet
Date: Tue Oct 15 2013 - 14:36:47 EST


On Tue, 2013-10-15 at 12:47 -0500, Christoph Lameter wrote:
> plain text document attachment (fix_snmp)
> ip4_datagram_connect is called with BH processing enabled. Therefore
> we cannot use IP_INC_STATS_BH but must use IP_INC_STATS which disables
> BH handling before incrementing the counter.
>
> The following trace is triggered without this patch:

> Cc: Eric Dumazet <edumazet@xxxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx
> Cc: David Miller <davem@xxxxxxxxxxxxx>
> Signed-off-by: Christoph Lameter <cl@xxxxxxxxx>

Strange, I thought I already Acked it...

Acked-by: Eric Dumazet <edumazet@xxxxxxxxxx>



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/