Re: [PATCH 1/1] AHCI: disabled FBS prior to issuing software reset

[Tejun Heo]

Hello,

On Tue, Oct 15, 2013 at 11:40:27AM +0800, xiangliang yu wrote:
> @@ -1278,6 +1280,11 @@ int ahci_do_softreset(struct ata_link *link,
> unsigned int *class,
>   if (rc && rc != -EOPNOTSUPP)
>   ata_link_warn(link, "failed to reset engine (errno=%d)\n", rc);
> 

Please add a comment here.

> + if (!ata_is_host_link(link) && pp->fbs_enabled) {
> + ahci_disable_fbs(ap);
> + fbs_flag = true;
> + }

White space damaged?

> +
>   ata_tf_init(link->device, &tf);
> 
>   /* issue the first D2H Register FIS */
> @@ -1318,6 +1325,9 @@ int ahci_do_softreset(struct ata_link *link,
> unsigned int *class,
>   } else
>   *class = ahci_dev_classify(ap);
> 
> + if (fbs_flag)
> + ahci_enable_fbs(ap);
> +

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/