Re: [PATCH] checkpatch: Allow spaces before the ':' of a bitfield

[Joe Perches]

On Mon, 2013-10-14 at 10:32 -0700, Josh Triplett wrote:
> checkpatch warns about spaces both before and after the ':' separating a
> bitfield name from its width.  However, many drivers do put space before
> the : to line up the widths, which makes the definition significantly
> more readable; checkpatch should not warn about that.  Remove the
> warning for space before the ':' of a bitfield.

There are a _bunch_ of different styles used for
alignment of bitfields.

$ grep -rPh --include=*.[ch] \
  '(?:unsigned\s+|signed\s+|)(char|short|long|long\s+long|\w+_t|(?:__|)(?:u|s)(?:8|16|32|64))\s+\w+\s*:\s*\d+\s*(?:,|;)' *

spaces before colon
spaces after colon
aligned on bitfield size

I'd just as soon make it a --strict check.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/