Re: [PATCH v3 10/10] intel_mid: Moved SFI related code to intel_mid_sfi.c

[H. Peter Anvin]

On 10/11/2013 08:43 PM, David Cohen wrote:
> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>
> 
> Moved SFI specific parsing/handling code to intel_mid_sfi.c. This will enable
> us to reuse our intel-mid code for platforms that supports firmware interfaces
> other than SFI (like ACPI).
> 
> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>
> Signed-off-by: David Cohen <david.a.cohen@xxxxxxxxxxxxxxx>
> ---
>  arch/x86/include/asm/intel-mid.h            |   1 +
>  arch/x86/platform/intel-mid/Makefile        |   5 +-
>  arch/x86/platform/intel-mid/intel-mid.c     | 450 --------------------------
>  arch/x86/platform/intel-mid/intel_mid_sfi.c | 485 ++++++++++++++++++++++++++++
>  4 files changed, 489 insertions(+), 452 deletions(-)
>  create mode 100644 arch/x86/platform/intel-mid/intel_mid_sfi.c
> 

Why not just sfi.c?  It is already in a directly named intel-mid.

I presume otherwise this is just code movement... I haven't verified
that, but it looked like it.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/