Re: [RFC][PATCH 4/7] sched: power: Remove power capacity hints forkworker threads

From: Arjan van de Ven
Date: Mon Oct 14 2013 - 11:14:31 EST


On 10/14/2013 6:33 AM, Peter Zijlstra wrote:
On Fri, Oct 11, 2013 at 06:19:14PM +0100, Morten Rasmussen wrote:
Removing power hints for kworker threads enables easier use of
workqueues in the power driver late callback. That would otherwise
lead to an endless loop unless it is prevented in the power driver.

There's many kworker users; some of them actually consume lots of
cputime. Therefore how did you come to the conclusion that excepting all
users was the better choice of a little added complexity in the one
place where it actually matters?

.. and likely only for a very few architectures

x86, and I suspect modern ARM, can change frequency synchronously.
(using an instruction or maybe two or three for ARM)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/