Re: [RFC][PATCH 3/7] sched: power: go_faster/slower power driverhints

[Peter Zijlstra]

On Fri, Oct 11, 2013 at 06:19:13PM +0100, Morten Rasmussen wrote:
> +static inline void inc_cpu_capacity(int cpu)
> +{
> +	if (weighted_cpuload(cpu) > power_of(cpu))
> +		go_faster(cpu, 0);
> +}
> +
> +static inline void dec_cpu_capacity(int cpu)
> +{
> +	if (weighted_cpuload(cpu) < power_of(cpu))
> +		go_slower(cpu, 0);
> +}

It seems wrong to me to use weighted_cpuload() here; that contains the
task weight, which is irrelevant to power usage. I would expect a pure
utilization term here.

Something like:

  se->avg.runnable_avg_sum / se->avg.runnable_avg_period


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/