Re: [PATCH 3/8] ACPI, x86: Extended error log driver for x86 platform

From: Borislav Petkov
Date: Mon Oct 14 2013 - 09:29:12 EST


On Mon, Oct 14, 2013 at 09:03:11AM -0400, Chen Gong wrote:
> This kind of mask is often unsigned. So how about following mode:
>
> GENMASKL / GENMASKQ
> or
> GENMASK_L / GENMASK_Q

Right, I think the "_ULL" thing is more accepted in the kernel, see
DIV_ROUND_UP{,_ULL}. Also, Joe had a patch to convert BIT to that
scheme too:

https://lkml.org/lkml/2013/9/19/307

There are macros with "_Q" but it does not necessarily mean Quadword but
something else like queues and stuff.

Thanks.

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/