Re: [PATCH 0/6] percpu: Implement Preemption checks for __this_cpuoperations V4

From: Peter Zijlstra
Date: Mon Oct 14 2013 - 06:33:20 EST


On Sat, Oct 12, 2013 at 06:51:20PM +0200, Ingo Molnar wrote:
> Another problem is that the patch emails are not properly threaded to the
> 0/6 patch and thus appear out of order and mixed up:
>
> 66216 N C Oct 11 Christoph Lamet ( 36) [PATCH 0/6] percpu: Implement Preemption checks for __this_cpu operations V4
> 66217 N C Oct 11 David Miller ( 13) ââ>
> 66218 N C Oct 11 Christoph Lamet ( 43) ââ>[PATCH 1/6] net: ip4_datagram_connect: Use correct form of statistics update
> 66219 N C Oct 11 Eric Dumazet ( 17) â ââ>
> 66220 N C Oct 11 Christoph Lamet ( 121) ââ>[PATCH 2/6] percpu: Add raw_cpu_ops
> 66221 N C Oct 11 Christoph Lamet ( 189) ââ>[PATCH 6/6] percpu: Add preemption checks to __this_cpu ops
> 66222 N C Oct 11 Christoph Lamet ( 64) ââ>[PATCH 5/6] net: __this_cpu_inc in route.c
> 66223 N C Oct 11 Christoph Lamet ( 103) ââ>[PATCH 3/6] mm: Use raw_cpu ops for determining current NUMA node
> 66224 N C Oct 11 Christoph Lamet ( 43) ââ>[PATCH 4/6] Use raw_cpu_write for initialization of per cpu refcount.
>
> Note how the order is 1,2,6,5,3,4 with no threading instead of 1,2,3,4,5,6
> with proper threading.
>
> That won't cause email servers to reject the mails, it just makes the
> patches a bit harder to review.
>
> Most kernel developers tend to use 'git send-email' to send patches to
> lkml, and that method is working pretty reliably.

I always use quilt mail, it typically adds a reference to the 0/0 email
and ensures the time of each msg is one second ahead of the previous one
to ensure order is correct.

I've no idea how Christoph managed to wreck this, but normally quilt
mail DTRT (as opposed to git send-email which used to default to
endlessly deep threads -- got fixed in 1.6 or 1.7 or thereabouts).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/